Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix pre-check for account balance under EIP-1559 #23244

Merged
merged 6 commits into from
Jul 22, 2021
Merged

core: fix pre-check for account balance under EIP-1559 #23244

merged 6 commits into from
Jul 22, 2021

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Jul 21, 2021 •
edited by fjl
Loading

We need to account for the value transacted in the buyGas() stage, since it would otherwise
mean our check would be

assert balance >= maxFeePerGas * gas

instead of

assert balance >= tx.value + maxFeePerGas * gas

holiman
holiman approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MariusVanDerWijden !

@holiman
Copy link
Contributor

holiman commented Jul 21, 2021

I added a repro-example, which can be used by other clients to verify the behaviour. cc @winsvega @MarekM25 .

@fjl fjl merged commit 97aacd9 into ethereum:master Jul 22, 2021
@fjl fjl added this to the 1.10.6 milestone Jul 22, 2021
@fjl fjl changed the title core: check that account has enough balance for value + gas * gasFeeCap core: fix pre-check for account balance under EIP-1559 Jul 22, 2021
connorwstein
connorwstein reviewed Jul 22, 2021
View reviewed changes
core/state_transition.go
@@ -193,6 +193,7 @@ func (st *StateTransition) buyGas() error {
if st.gasFeeCap != nil {
balanceCheck = new(big.Int).SetUint64(st.msg.Gas())
balanceCheck = balanceCheck.Mul(balanceCheck, st.gasFeeCap)
balanceCheck.Add(balanceCheck, st.value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI this change makes this comment stale

go-ethereum/core/state_transition.go

Line 267 in f68a68a

// 2. caller has enough balance to cover transaction fee(gaslimit * gasprice)

@vieyang vieyang mentioned this pull request Jul 23, 2021
Merged
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Jul 28, 2021
@MariusVanDerWijden @holiman
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
e8906cd 
When processing a transaction with London fork rules, EIP-1559 mandates
checking that the sender must have sufficient balance to cover gas * gasFeeCap.

In the EIP's pseudocode, this check happens after the value transferred by the
transaction has already been deducted. However, in go-ethereum, the balance
has not yet been updated when the check happens, and therefore needs to be
added explicitly.

Co-authored-by: Martin Holst Swende <[email protected]>
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@MariusVanDerWijden @holiman @atif-konasl
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
90bc3bc 
When processing a transaction with London fork rules, EIP-1559 mandates
checking that the sender must have sufficient balance to cover gas * gasFeeCap.

In the EIP's pseudocode, this check happens after the value transferred by the
transaction has already been deducted. However, in go-ethereum, the balance
has not yet been updated when the check happens, and therefore needs to be
added explicitly.

Co-authored-by: Martin Holst Swende <[email protected]>
@MariusVanDerWijden MariusVanDerWijden deleted the ropsten-issue branch November 30, 2021 15:26
@sirano11 sirano11 mentioned this pull request Feb 10, 2022
Merged
9 tasks
This was referenced Sep 23, 2022
Closed
Merged
misterchenleiya pushed a commit to J1a-wei/go-ethereum that referenced this pull request Jun 26, 2023
@holiman
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
f474c70 
When processing a transaction with London fork rules, EIP-1559 mandates
checking that the sender must have sufficient balance to cover gas * gasFeeCap.

In the EIP's pseudocode, this check happens after the value transferred by the
transaction has already been deducted. However, in go-ethereum, the balance
has not yet been updated when the check happens, and therefore needs to be
added explicitly.

Co-authored-by: Martin Holst Swende <[email protected]>
misterchenleiya pushed a commit to J1a-wei/go-ethereum that referenced this pull request Jun 26, 2023
Merge branch 'shiliuhui' into 'task/huobi'
4a46398 
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)

See merge request dongwei/blockchain-go-ethereum!3
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
68c59ea
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
cf2cf34
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
ee59e3f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
a240429
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
6240966
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
259e1a3
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
61f7ebf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
95ecaef
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
00ce543
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
eda44bb
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
8def266
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
1d22545
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
af356ff
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
02b8341
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
d10be7c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
703006b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
8d2ba38
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
7fef242
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
f96b987
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
7200dd4
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
df1724e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
fdb0c86
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
ec669a0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
487a93c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
87c3015
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
c8b0ddc
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
09b6960
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
74efa5b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@gzliudan
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
43a0cdf
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
@gzliudan @wanwiset25
core: fix pre-check for account balance under EIP-1559 (ethereum#23244)
2fe76b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorwstein connorwstein connorwstein left review comments

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

Assignees
No one assigned
Labels
london
Projects
None yet
Milestone
1.10.6
Development

Successfully merging this pull request may close these issues.
5 participants
@MariusVanDerWijden @holiman @connorwstein @rjl493456442 @fjl